caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a testcase for Clang modules being updated within one LLDB session.

Browse Source 
This actually works as expected, but wasn't explicitly tested before.
This commit is contained in:
Adrian Prantl
2019-11-15 16:25:46 -08:00
parent d295087639
commit 0304360a40
7 changed files with 91 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lldb/source/Core/ModuleList.cpp
View File

@@ -752,9 +752,10 @@ Status ModuleList::GetSharedModule(const ModuleSpec &module_spec,
Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_MODULES));
if (log != nullptr)
LLDB_LOGF(log,
"module changed: %p, removing from global module list",
static_cast<void *>(module_sp.get()));
LLDB_LOGF(
log, "%p '%s' module changed: removing from global module list",
static_cast<void *>(module_sp.get()),
module_sp->GetFileSpec().GetFilename().GetCString());
shared_module_list.Remove(module_sp);
module_sp.reset();