Fix is_noexcept for implicit noexcept destructors when marked as default or deleted (#196)

clang/lib/AST/ExprConstantMeta.cpp

@@ -1481,13 +1481,12 @@ static bool isFunctionOrMethodNoexcept(const QualType QT) {
   if (T->isFunctionProtoType()) {
     // This covers (virtual) methods & functions
     const auto *FPT = T->getAs<FunctionProtoType>();
-
     switch (FPT->getExceptionSpecType()) {
-    case EST_BasicNoexcept:
+      case EST_BasicNoexcept:
-    case EST_NoexceptTrue:
+      case EST_NoexceptTrue:
-      return true;
+        return true;
-    default:
+      default:
-      return false;
+        return false;
     }
   }
 

clang/lib/Sema/SemaReflect.cpp

@@ -349,7 +349,13 @@ public:
 
   void EnsureInstantiationOfExceptionSpec(SourceLocation Loc,
                                           FunctionDecl *FD) override {
-    S.InstantiateExceptionSpec(Loc, FD);
+    const FunctionProtoType *Proto = FD->getType()->castAs<FunctionProtoType>();
+    if (Proto->getExceptionSpecType() == EST_Uninstantiated) {
+      S.InstantiateExceptionSpec(Loc, FD);
+    }
+    if (Proto->getExceptionSpecType() == EST_Unevaluated) {
+      S.ResolveExceptionSpec(Loc, Proto);
+    }
   }
 
   QualType Substitute(TypeAliasTemplateDecl *TD,

libcxx/test/std/experimental/reflection/member-classification.pass.cpp

@@ -703,6 +703,16 @@ static_assert(!is_noexcept(type_of(^^EC::Something)));
 static_assert(!is_noexcept(^^E));
 static_assert(!is_noexcept(^^E_Something));
 static_assert(!is_noexcept(type_of(^^E_Something)));
+
+// Defaulted special members
+struct DelDest { ~DelDest() = delete; };
+static_assert(is_noexcept (^^DelDest::~DelDest));
+
+struct DefDest { ~DefDest() = default; };
+static_assert(is_noexcept (^^DefDest::~DefDest));
+
+struct EmptyStruct { };
+static_assert(is_noexcept (^^EmptyStruct::~EmptyStruct));
 } // namespace noexcept_functions
 
                               // ================