caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[BitcodeReader] Change order of assignValue() arguments (NFC)

Browse Source 
Other methods in ValueList generally pass Idx first, and it is
more convention for assignment methods to have the target on the
LHS rather than RHS.
This commit is contained in:
Nikita Popov
2022-02-15 10:09:48 +01:00
parent a081a0654f
commit 093e9489d5
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
View File

@@ -2454,7 +2454,7 @@ Error BitcodeReader::parseConstants() {
SmallVector<int, 16> Mask;
ShuffleVectorInst::getShuffleMask(Op2, Mask);
Value *V = ConstantExpr::getShuffleVector(Op0, Op1, Mask);
ValueList.assignValue(V, CstNo);
ValueList.assignValue(CstNo, V);
}
for (auto &DelayedSelector : DelayedSelectors) {
Type *OpTy = DelayedSelector.OpTy;
@@ -2475,7 +2475,7 @@ Error BitcodeReader::parseConstants() {
}
Constant *Op0 = ValueList.getConstantFwdRef(Op0Idx, SelectorTy);
Value *V = ConstantExpr::getSelect(Op0, Op1, Op2);
ValueList.assignValue(V, CstNo);
ValueList.assignValue(CstNo, V);
}
if (NextCstNo != ValueList.size())
@@ -3062,7 +3062,7 @@ Error BitcodeReader::parseConstants() {
}
}
ValueList.assignValue(V, NextCstNo);
ValueList.assignValue(NextCstNo, V);
++NextCstNo;
}
}
@@ -5604,7 +5604,7 @@ Error BitcodeReader::parseFunctionBody(Function *F) {
// Non-void values get registered in the value table for future use.
if (!I->getType()->isVoidTy())
ValueList.assignValue(I, NextValueNo++);
ValueList.assignValue(NextValueNo++, I);
}
OutOfRecordLoop: