caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb/crashlog] Create artificial frames for non-crashed scripted threads

Browse Source 
This patch pipes down the `-a|--load-all` crashlog command option to the
Scripted Process initializer to load all the images used by crashed
process instead of only loading the images related to the crashed
thread.

This allows us to recreate artificial frames also for the non-crashed
scripted threads.

rdar://90396265

Differential Revision: https://reviews.llvm.org/D121826

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
This commit is contained in:
Med Ismail Bennani
2022-03-16 15:44:31 -07:00
parent 0c4e9fbf41
commit 0a65112cf7
5 changed files with 519 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
lldb/examples/python/scripted_process/crashlog_scripted_process.py
View File

@@ -19,18 +19,24 @@ class CrashLogScriptedProcess(ScriptedProcess):
self.crashed_thread_idx = crash_log.crashed_thread_idx
self.loaded_images = []
def load_images(self, images):
#TODO: Add to self.loaded_images and load images in lldb
if images:
for image in images:
if image not in self.loaded_images:
err = image.add_module(self.target)
if err:
print(err)
else:
self.loaded_images.append(image)
for thread in crash_log.threads:
if thread.did_crash():
if self.load_all_images:
load_images(self, crash_log.images)
elif thread.did_crash():
for ident in thread.idents:
images = crash_log.find_images_with_identifier(ident)
if images:
for image in images:
#TODO: Add to self.loaded_images and load images in lldb
err = image.add_module(self.target)
if err:
print(err)
else:
self.loaded_images.append(image)
load_images(self, crash_log.find_images_with_identifier(ident))
self.threads[thread.index] = CrashLogScriptedThread(self, None, thread)
def __init__(self, target: lldb.SBTarget, args : lldb.SBStructuredData):
@@ -49,6 +55,14 @@ class CrashLogScriptedProcess(ScriptedProcess):
if not self.crashlog_path:
return
load_all_images = args.GetValueForKey("load_all_images")
if load_all_images and load_all_images.IsValid():
if load_all_images.GetType() == lldb.eStructuredDataTypeBoolean:
self.load_all_images = load_all_images.GetBooleanValue()
if not self.load_all_images:
self.load_all_images = False
self.pid = super().get_process_id()
self.crashed_thread_idx = 0
self.parse_crashlog()
@@ -101,7 +115,7 @@ class CrashLogScriptedThread(ScriptedThread):
return self.register_ctx
def create_stackframes(self):
if not self.has_crashed:
if not (self.scripted_process.load_all_images or self.has_crashed):
return None
if not self.backing_thread or not len(self.backing_thread.frames):