[lldb] Eliminate unneeded value parameters in Utility (NFC)

Eliminates value parameter for types that are not trivially copyable.
This commit is contained in:
Jonas Devlieghere
2020-07-22 13:33:03 -07:00
parent 8b56b03f5a
commit 0d5fc82245
17 changed files with 49 additions and 43 deletions

View File

@@ -54,12 +54,12 @@ XcodeSDK::XcodeSDK(XcodeSDK::Info info) : m_name(GetName(info.type).str()) {
}
}
XcodeSDK &XcodeSDK::operator=(XcodeSDK other) {
XcodeSDK &XcodeSDK::operator=(const XcodeSDK &other) {
m_name = other.m_name;
return *this;
}
bool XcodeSDK::operator==(XcodeSDK other) {
bool XcodeSDK::operator==(const XcodeSDK &other) {
return m_name == other.m_name;
}
@@ -147,7 +147,7 @@ bool XcodeSDK::Info::operator==(const Info &other) const {
std::tie(other.type, other.version, other.internal);
}
void XcodeSDK::Merge(XcodeSDK other) {
void XcodeSDK::Merge(const XcodeSDK &other) {
// The "bigger" SDK always wins.
auto l = Parse();
auto r = other.Parse();