caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "[lldb] Use current execution context in SBDebugger"

Browse Source 
This reverts commit 754ab803b8.

As pointed out in https://reviews.llvm.org/D95761, this patch could lead to
having the wrong execution context in some situations (thanks Jim!).

D92164 is addressing the same issue and will replace this patch, so I'll
revert this one.
This commit is contained in:
Raphael Isemann
2021-02-02 14:41:41 +01:00
parent 3d3ca8f8eb
commit 0f2be195d5
2 changed files with 4 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
lldb/test/API/python_api/debugger/TestDebuggerAPI.py
View File

@@ -43,35 +43,3 @@ class DebuggerAPITestCase(TestBase):
target = lldb.SBTarget()
self.assertFalse(target.IsValid())
self.dbg.DeleteTarget(target)
@add_test_categories(['pyapi'])
def test_debugger_internal_variables(self):
debugger_name = self.dbg.GetInstanceName()
# Set a variable and check it was written successfully.
error = lldb.SBDebugger.SetInternalVariable(
'target.prefer-dynamic-value', 'no-dynamic-values', debugger_name)
self.assertTrue(error.Success())
ret = lldb.SBDebugger.GetInternalVariableValue(
'target.prefer-dynamic-value', debugger_name)
self.assertEqual(ret.GetSize(), 1)
self.assertEqual(ret.GetStringAtIndex(0), 'no-dynamic-values')
# Set a variable with a different value.
error = lldb.SBDebugger.SetInternalVariable(
'target.prefer-dynamic-value', 'no-run-target', debugger_name)
self.assertTrue(error.Success())
ret = lldb.SBDebugger.GetInternalVariableValue(
'target.prefer-dynamic-value', debugger_name)
self.assertEqual(ret.GetSize(), 1)
self.assertEqual(ret.GetStringAtIndex(0), 'no-run-target')
# Try setting invalid value, check for error.
error = lldb.SBDebugger.SetInternalVariable(
'target.prefer-dynamic-value', 'dummy-value', debugger_name)
self.assertTrue(error.Fail())
# Check that the value didn't change.
ret = lldb.SBDebugger.GetInternalVariableValue(
'target.prefer-dynamic-value', debugger_name)
self.assertEqual(ret.GetSize(), 1)
self.assertEqual(ret.GetStringAtIndex(0), 'no-run-target')