From 1433c3e997ef7cc29f460d7b2f5da813acd0cafa Mon Sep 17 00:00:00 2001 From: Asher Mancinelli Date: Tue, 29 Apr 2025 06:47:13 -0700 Subject: [PATCH] [flang] Remove dead functions for getting LLVM intrinsics (#137743) In cleaning up LowLevelIntrinsics I found some uncalled functions. We would like to remove direct calls to llvm instructions wherever possible to make it easier on consumers of our IR to match LLVM intrinsics, so if this code is needed again we should use the op from the llvm dialect instead anyways. --- .../flang/Optimizer/Builder/LowLevelIntrinsics.h | 3 --- flang/lib/Optimizer/Builder/LowLevelIntrinsics.cpp | 10 ---------- 2 files changed, 13 deletions(-) diff --git a/flang/include/flang/Optimizer/Builder/LowLevelIntrinsics.h b/flang/include/flang/Optimizer/Builder/LowLevelIntrinsics.h index 45499906e39f..9303f09d42fb 100644 --- a/flang/include/flang/Optimizer/Builder/LowLevelIntrinsics.h +++ b/flang/include/flang/Optimizer/Builder/LowLevelIntrinsics.h @@ -24,9 +24,6 @@ class FirOpBuilder; namespace fir::factory { -/// Get the LLVM intrinsic for `memset`. Use the 64 bit version. -mlir::func::FuncOp getLlvmMemset(FirOpBuilder &builder); - /// Get the C standard library `realloc` function. mlir::func::FuncOp getRealloc(FirOpBuilder &builder); diff --git a/flang/lib/Optimizer/Builder/LowLevelIntrinsics.cpp b/flang/lib/Optimizer/Builder/LowLevelIntrinsics.cpp index 73fd8fa0c2b6..64d70d70829f 100644 --- a/flang/lib/Optimizer/Builder/LowLevelIntrinsics.cpp +++ b/flang/lib/Optimizer/Builder/LowLevelIntrinsics.cpp @@ -21,16 +21,6 @@ #include "flang/Optimizer/Builder/LowLevelIntrinsics.h" #include "flang/Optimizer/Builder/FIRBuilder.h" -mlir::func::FuncOp fir::factory::getLlvmMemset(fir::FirOpBuilder &builder) { - auto ptrTy = builder.getRefType(builder.getIntegerType(8)); - llvm::SmallVector args = {ptrTy, ptrTy, builder.getI64Type(), - builder.getI1Type()}; - auto memsetTy = - mlir::FunctionType::get(builder.getContext(), args, std::nullopt); - return builder.createFunction(builder.getUnknownLoc(), - "llvm.memset.p0.p0.i64", memsetTy); -} - mlir::func::FuncOp fir::factory::getRealloc(fir::FirOpBuilder &builder) { auto ptrTy = builder.getRefType(builder.getIntegerType(8)); llvm::SmallVector args = {ptrTy, builder.getI64Type()};