From 163a7e1b4fad52c69a546a0eff05d401dc00a076 Mon Sep 17 00:00:00 2001 From: Robert Konicar Date: Mon, 30 Jun 2025 21:57:05 +0200 Subject: [PATCH] [mlir][LLVMIR][NFC] Remove duplicate getUnnamedAddrAttrName uses in op printers (#146090) Fix `UnnamedAddrAttrName` being inserted twice into the `elidedAttrs` list for the attribute dictionary printer in `GlobalOp` and `AliasOp` print functions. --- mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp index 727646438955..dfaca6048fe0 100644 --- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp +++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp @@ -2245,8 +2245,7 @@ void GlobalOp::print(OpAsmPrinter &p) { getGlobalTypeAttrName(), getConstantAttrName(), getValueAttrName(), getLinkageAttrName(), getUnnamedAddrAttrName(), getThreadLocal_AttrName(), - getVisibility_AttrName(), getComdatAttrName(), - getUnnamedAddrAttrName()}); + getVisibility_AttrName(), getComdatAttrName()}); // Print the trailing type unless it's a string global. if (llvm::dyn_cast_or_null(getValueOrNull())) @@ -2588,7 +2587,7 @@ void AliasOp::print(OpAsmPrinter &p) { {SymbolTable::getSymbolAttrName(), getAliasTypeAttrName(), getLinkageAttrName(), getUnnamedAddrAttrName(), getThreadLocal_AttrName(), - getVisibility_AttrName(), getUnnamedAddrAttrName()}); + getVisibility_AttrName()}); // Print the trailing type. p << " : " << getType() << ' ';