caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Thread hardening part 3. Now lldb_private::Thread objects have std::weak_ptr

Browse Source 
objects for the backlink to the lldb_private::Process. The issues we were
running into before was someone was holding onto a shared pointer to a 
lldb_private::Thread for too long, and the lldb_private::Process parent object
would get destroyed and the lldb_private::Thread had a "Process &m_process"
member which would just treat whatever memory that used to be a Process as a
valid Process. This was mostly happening for lldb_private::StackFrame objects
that had a member like "Thread &m_thread". So this completes the internal
strong/weak changes.

Documented the ExecutionContext and ExecutionContextRef classes so that our
LLDB developers can understand when and where to use ExecutionContext and 
ExecutionContextRef objects.

llvm-svn: 151009
This commit is contained in:
Greg Clayton
2012-02-21 00:09:25 +00:00
parent 3508a00543
commit 1ac04c3088
65 changed files with 1534 additions and 837 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/source/Interpreter/ScriptInterpreterPython.cpp
View File

@@ -1496,7 +1496,8 @@ ScriptInterpreterPython::BreakpointCallbackFunction
if (!context)
return true;
Target *target = context->exe_ctx.GetTargetPtr();
ExecutionContext exe_ctx (context->exe_ctx_ref);
Target *target = exe_ctx.GetTargetPtr();
if (!target)
return true;
@@ -1511,7 +1512,7 @@ ScriptInterpreterPython::BreakpointCallbackFunction
if (python_function_name != NULL
&& python_function_name[0] != '\0')
{
const StackFrameSP stop_frame_sp (context->exe_ctx.GetFrameSP());
const StackFrameSP stop_frame_sp (exe_ctx.GetFrameSP());
BreakpointSP breakpoint_sp = target->GetBreakpointByID (break_id);
if (breakpoint_sp)
{