caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] NFC modernize codebase with modernize-use-nullptr

Browse Source 
Summary:
NFC = [[ https://llvm.org/docs/Lexicon.html#nfc | Non functional change ]]

This commit is the result of modernizing the LLDB codebase by using
`nullptr` instread of `0` or `NULL`. See
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
for more information.

This is the command I ran and I to fix and format the code base:

```
run-clang-tidy.py \
	-header-filter='.*' \
	-checks='-*,modernize-use-nullptr' \
	-fix ~/dev/llvm-project/lldb/.* \
	-format \
	-style LLVM \
	-p ~/llvm-builds/debug-ninja-gcc
```

NOTE: There were also changes to `llvm/utils/unittest` but I did not
include them because I felt that maybe this library shall be updated in
isolation somehow.

NOTE: I know this is a rather large commit but it is a nobrainer in most
parts.

Reviewers: martong, espindola, shafik, #lldb, JDevlieghere

Reviewed By: JDevlieghere

Subscribers: arsenm, jvesely, nhaehnle, hiraditya, JDevlieghere, teemperor, rnkovacs, emaste, kubamracek, nemanjai, ki.stfu, javed.absar, arichardson, kbarton, jrtc27, MaskRay, atanasyan, dexonsmith, arphaman, jfb, jsji, jdoerfert, lldb-commits, llvm-commits

Tags: #lldb, #llvm

Differential Revision: https://reviews.llvm.org/D61847

llvm-svn: 361484
This commit is contained in:
Konrad Kleine
2019-05-23 11:14:47 +00:00
parent 32d976bac1
commit 248a13057a
250 changed files with 1487 additions and 1461 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lldb/source/API/SBError.cpp
View File

@@ -41,7 +41,7 @@ const char *SBError::GetCString() const {
if (m_opaque_up)
return m_opaque_up->AsCString();
return NULL;
return nullptr;
}
void SBError::Clear() {
@@ -144,11 +144,11 @@ bool SBError::IsValid() const {
SBError::operator bool() const {
LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBError, operator bool);
return m_opaque_up != NULL;
return m_opaque_up != nullptr;
}
void SBError::CreateIfNeeded() {
if (m_opaque_up == NULL)
if (m_opaque_up == nullptr)
m_opaque_up.reset(new Status());
}
@@ -175,7 +175,8 @@ bool SBError::GetDescription(SBStream &description) {
description.Printf("success");
else {
const char *err_string = GetCString();
description.Printf("error: %s", (err_string != NULL ? err_string : ""));
description.Printf("error: %s",
(err_string != nullptr ? err_string : ""));
}
} else
description.Printf("error: <NULL>");