caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update StructuredData::String to return StringRefs.

Browse Source 
It was returning const std::string& which was leading to
unnecessary copies all over the place, and preventing people
from doing things like Dict->GetValueForKeyAsString("foo", ref);

llvm-svn: 302875
This commit is contained in:
Zachary Turner
2017-05-12 05:49:54 +00:00
parent 41c9936460
commit 2833321f09
32 changed files with 122 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
View File

@@ -240,8 +240,8 @@ ThreadSP OperatingSystemPython::CreateThreadFromThreadInfo(
uint32_t core_number;
addr_t reg_data_addr;
std::string name;
std::string queue;
llvm::StringRef name;
llvm::StringRef queue;
thread_dict.GetValueForKeyAsInteger("core", core_number, UINT32_MAX);
thread_dict.GetValueForKeyAsInteger("register_data_addr", reg_data_addr,
@@ -266,8 +266,8 @@ ThreadSP OperatingSystemPython::CreateThreadFromThreadInfo(
if (!thread_sp) {
if (did_create_ptr)
*did_create_ptr = true;
thread_sp.reset(new ThreadMemory(*m_process, tid, name.c_str(),
queue.c_str(), reg_data_addr));
thread_sp.reset(
new ThreadMemory(*m_process, tid, name, queue, reg_data_addr));
}
if (core_number < core_thread_list.GetSize(false)) {