caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporarily Revert "Reland [lldb] Unify type name matching in FormattersContainer"

Browse Source 
as it breaks bots with due to m_valid being an unused class member
except in assert builds.

This reverts commit 074b121642.
This commit is contained in:
Eric Christopher
2020-07-23 00:46:03 -07:00
parent 55c0f12a86
commit 3a75466f41
10 changed files with 179 additions and 302 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/source/DataFormatters/DataVisualization.cpp
View File

@@ -174,7 +174,8 @@ bool DataVisualization::NamedSummaryFormats::GetSummaryFormat(
void DataVisualization::NamedSummaryFormats::Add(
ConstString type, const lldb::TypeSummaryImplSP &entry) {
GetFormatManager().GetNamedSummaryContainer().Add(type, entry);
GetFormatManager().GetNamedSummaryContainer().Add(
FormatManager::GetValidTypeName(type), entry);
}
bool DataVisualization::NamedSummaryFormats::Delete(ConstString type) {
@@ -186,7 +187,7 @@ void DataVisualization::NamedSummaryFormats::Clear() {
}
void DataVisualization::NamedSummaryFormats::ForEach(
std::function<bool(const TypeMatcher &, const lldb::TypeSummaryImplSP &)>
std::function<bool(ConstString, const lldb::TypeSummaryImplSP &)>
callback) {
GetFormatManager().GetNamedSummaryContainer().ForEach(callback);
}