caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb/Reproducers] Serialize empty string for char* methods.

Browse Source 
For the methods taking a char* and a length that have a custom replayer,
ignore the incoming string in the instrumentation macro. This prevents
potentially reading garbage and blowing up the SB API log.
This commit is contained in:
Jonas Devlieghere
2020-02-05 21:20:12 -08:00
parent 8dc3da7d58
commit 3da7dcf38a
4 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lldb/source/API/SBThread.cpp
View File

@@ -313,8 +313,8 @@ SBThread::GetStopReasonExtendedBacktraces(InstrumentationRuntimeType type) {
}
size_t SBThread::GetStopDescription(char *dst, size_t dst_len) {
LLDB_RECORD_METHOD(size_t, SBThread, GetStopDescription, (char *, size_t),
dst, dst_len);
LLDB_RECORD_METHOD(size_t, SBThread, GetStopDescription, (char *, size_t), "",
dst_len);
std::unique_lock<std::recursive_mutex> lock;
ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
@@ -970,23 +970,20 @@ SBError SBThread::StepUsingScriptedThreadPlan(const char *script_class_name) {
SBError SBThread::StepUsingScriptedThreadPlan(const char *script_class_name,
bool resume_immediately) {
LLDB_RECORD_METHOD(lldb::SBError, SBThread, StepUsingScriptedThreadPlan,
(const char *, bool), script_class_name,
(const char *, bool), script_class_name,
resume_immediately);
lldb::SBStructuredData no_data;
return LLDB_RECORD_RESULT(
StepUsingScriptedThreadPlan(script_class_name,
no_data,
resume_immediately));
return LLDB_RECORD_RESULT(StepUsingScriptedThreadPlan(
script_class_name, no_data, resume_immediately));
}
SBError SBThread::StepUsingScriptedThreadPlan(const char *script_class_name,
SBStructuredData &args_data,
bool resume_immediately) {
LLDB_RECORD_METHOD(lldb::SBError, SBThread, StepUsingScriptedThreadPlan,
(const char *, lldb::SBStructuredData &, bool),
script_class_name, args_data,
resume_immediately);
(const char *, lldb::SBStructuredData &, bool),
script_class_name, args_data, resume_immediately);
SBError error;