[mlir][vector] Use result consistently as the result argument name (#144739)
This patch updates the following ops to use `result` (instead of `res`) as the name for their result argument: * `vector.scalable.insert` * `vector.scalable.extract` * `vector.insert_strided_slice` This change ensures naming consistency with other ops in the `vector` dialect. It addresses part of: * https://github.com/llvm/llvm-project/issues/131602
This commit is contained in:
committed by
GitHub
parent
c0cc81cdc0
commit
3fe62682ef
@@ -1008,7 +1008,7 @@ def Vector_InsertOp :
|
||||
def Vector_ScalableInsertOp :
|
||||
Vector_Op<"scalable.insert", [Pure,
|
||||
AllElementTypesMatch<["valueToStore", "dest"]>,
|
||||
AllTypesMatch<["dest", "res"]>,
|
||||
AllTypesMatch<["dest", "result"]>,
|
||||
PredOpTrait<"position is a multiple of the source length.",
|
||||
CPred<
|
||||
"(getPos() % getSourceVectorType().getNumElements()) == 0"
|
||||
@@ -1016,7 +1016,7 @@ def Vector_ScalableInsertOp :
|
||||
Arguments<(ins VectorOfRank<[1]>:$valueToStore,
|
||||
ScalableVectorOfRank<[1]>:$dest,
|
||||
I64Attr:$pos)>,
|
||||
Results<(outs ScalableVectorOfRank<[1]>:$res)> {
|
||||
Results<(outs ScalableVectorOfRank<[1]>:$result)> {
|
||||
let summary = "insert subvector into scalable vector operation";
|
||||
// NOTE: This operation is designed to map to `llvm.vector.insert`, and its
|
||||
// documentation should be kept aligned with LLVM IR:
|
||||
@@ -1059,19 +1059,23 @@ def Vector_ScalableInsertOp :
|
||||
VectorType getDestVectorType() {
|
||||
return ::llvm::cast<VectorType>(getDest().getType());
|
||||
}
|
||||
/// Wrapper for getResult, which replaced getRes.
|
||||
[[deprecated("Use getResult instead!")]] ::mlir::Value getRes() {
|
||||
return getResult();
|
||||
}
|
||||
}];
|
||||
}
|
||||
|
||||
def Vector_ScalableExtractOp :
|
||||
Vector_Op<"scalable.extract", [Pure,
|
||||
AllElementTypesMatch<["source", "res"]>,
|
||||
AllElementTypesMatch<["source", "result"]>,
|
||||
PredOpTrait<"position is a multiple of the result length.",
|
||||
CPred<
|
||||
"(getPos() % getResultVectorType().getNumElements()) == 0"
|
||||
>>]>,
|
||||
Arguments<(ins ScalableVectorOfRank<[1]>:$source,
|
||||
I64Attr:$pos)>,
|
||||
Results<(outs VectorOfRank<[1]>:$res)> {
|
||||
Results<(outs VectorOfRank<[1]>:$result)> {
|
||||
let summary = "extract subvector from scalable vector operation";
|
||||
// NOTE: This operation is designed to map to `llvm.vector.extract`, and its
|
||||
// documentation should be kept aligned with LLVM IR:
|
||||
@@ -1100,7 +1104,7 @@ def Vector_ScalableExtractOp :
|
||||
}];
|
||||
|
||||
let assemblyFormat = [{
|
||||
$source `[` $pos `]` attr-dict `:` type($res) `from` type($source)
|
||||
$source `[` $pos `]` attr-dict `:` type($result) `from` type($source)
|
||||
}];
|
||||
|
||||
let extraClassDeclaration = extraPoisonClassDeclaration # [{
|
||||
@@ -1108,7 +1112,11 @@ def Vector_ScalableExtractOp :
|
||||
return ::llvm::cast<VectorType>(getSource().getType());
|
||||
}
|
||||
VectorType getResultVectorType() {
|
||||
return ::llvm::cast<VectorType>(getRes().getType());
|
||||
return ::llvm::cast<VectorType>(getResult().getType());
|
||||
}
|
||||
/// Wrapper for getResult, which replaced getRes.
|
||||
[[deprecated("Use getResult instead!")]] ::mlir::Value getRes() {
|
||||
return getResult();
|
||||
}
|
||||
}];
|
||||
}
|
||||
@@ -1117,10 +1125,10 @@ def Vector_InsertStridedSliceOp :
|
||||
Vector_Op<"insert_strided_slice", [Pure,
|
||||
PredOpTrait<"operand #0 and result have same element type",
|
||||
TCresVTEtIsSameAsOpBase<0, 0>>,
|
||||
AllTypesMatch<["dest", "res"]>]>,
|
||||
AllTypesMatch<["dest", "result"]>]>,
|
||||
Arguments<(ins AnyVectorOfNonZeroRank:$valueToStore, AnyVectorOfNonZeroRank:$dest, I64ArrayAttr:$offsets,
|
||||
I64ArrayAttr:$strides)>,
|
||||
Results<(outs AnyVectorOfNonZeroRank:$res)> {
|
||||
Results<(outs AnyVectorOfNonZeroRank:$result)> {
|
||||
let summary = "strided_slice operation";
|
||||
let description = [{
|
||||
Takes a k-D valueToStore vector, an n-D destination vector (n >= k), n-sized
|
||||
@@ -1164,6 +1172,10 @@ def Vector_InsertStridedSliceOp :
|
||||
return ::llvm::cast<IntegerAttr>(attr).getInt() != 1;
|
||||
});
|
||||
}
|
||||
/// Wrapper for getResult, which replaced getRes.
|
||||
[[deprecated("Use getResult instead!")]] ::mlir::Value getRes() {
|
||||
return getResult();
|
||||
}
|
||||
}];
|
||||
|
||||
let hasFolder = 1;
|
||||
|
||||
Reference in New Issue
Block a user