caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Stop passing both i386 and i686 in parallel as architectures on Windows

Browse Source 
When an object file returns multiple architectures, it is treated
as a fat binary - which really isn't the case of i386 vs i686 where
the object file actually has one architecture.

This allows getting rid of hardcoded architecture triples in
PlatformWindows.

The parallel i386 and i686 architecture strings stem from
5e6f45201f / D7120 and
ad587ae4ca / D4658.

Differential Revision: https://reviews.llvm.org/D128617
This commit is contained in:
Martin Storsjö
2022-06-23 14:19:47 +03:00
parent f96cb66d19
commit 4270c9cd44
4 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
View File

@@ -337,9 +337,6 @@ size_t ObjectFilePECOFF::GetModuleSpecifications(
spec.SetTriple("i386-pc-windows");
spec.GetTriple().setEnvironment(env);
specs.Append(module_spec);
spec.SetTriple("i686-pc-windows");
spec.GetTriple().setEnvironment(env);
specs.Append(module_spec);
break;
case MachineArmNt:
spec.SetTriple("armv7-pc-windows");