Improve LLDB prompt handling

Summary:
There is an issue in lldb where the command prompt can appear at the wrong time. The partial fix
we have in for this is not working all the time and is introducing unnecessary delays. This
change does:
- Change Process:SyncIOHandler to use integer start id's for synchronization to avoid it being
  confused by quick start-stop cycles. I picked this up from a suggested patch by Greg to
  lldb-dev.
- coordinates printing of asynchronous text with the iohandlers. This is also based on a
  (different) Greg's patch, but I have added stronger synchronization to it to avoid races.

Together, these changes solve the prompt problem for me on linux (both with and without libedit).
I think they should behave similarly on Mac and FreeBSD and I think they will not make matters
worse for windows.

Test Plan: Prompt comes out alright. All tests still pass on linux.

Reviewers: clayborg, emaste, zturner

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D9823

llvm-svn: 238313
This commit is contained in:
Pavel Labath
2015-05-27 12:40:32 +00:00
parent bed77de002
commit 4446487d71
13 changed files with 317 additions and 407 deletions

View File

@@ -734,22 +734,21 @@ public:
}
virtual
~IOHandlerPythonInterpreter()
~IOHandlerPythonInterpreter() override
{
}
virtual ConstString
GetControlSequence (char ch)
ConstString
GetControlSequence (char ch) override
{
if (ch == 'd')
return ConstString("quit()\n");
return ConstString();
}
virtual void
Run ()
void
Run () override
{
if (m_python)
{
@@ -795,32 +794,20 @@ public:
SetIsDone(true);
}
virtual void
Hide ()
{
}
virtual void
Refresh ()
void
Cancel () override
{
}
virtual void
Cancel ()
{
}
virtual bool
Interrupt ()
bool
Interrupt () override
{
return m_python->Interrupt();
}
virtual void
GotEOF()
void
GotEOF() override
{
}