From 4f7b5e6d8327f8cea41ba31fdbbb0ee9c1f754c3 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 16 Jun 2025 07:49:20 -0400 Subject: [PATCH] Fix a tablegen pattern that results in a warning; NFC We were generating `1 || 1` which caused some issues for -Werror builds --- clang/utils/TableGen/ClangAttrEmitter.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp index 42627f02cf35..f892626a447e 100644 --- a/clang/utils/TableGen/ClangAttrEmitter.cpp +++ b/clang/utils/TableGen/ClangAttrEmitter.cpp @@ -3739,7 +3739,8 @@ static void GenerateHasAttrSpellingStringSwitch( : '(' + itostr(Version) + ')'; if (Scope.empty() || Scope == Spelling.nameSpace()) { - if (TestStringMap.contains(Spelling.name())) + if (TestStringMap.contains(Spelling.name()) && + TestStringMap[Spelling.name()] != TestStr) TestStringMap[Spelling.name()] += " || " + TestStr; else TestStringMap[Spelling.name()] = TestStr;