caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

OpaquePtr: Turn inalloca into a type attribute

Browse Source 
I think byval/sret and the others are close to being able to rip out
the code to support the missing type case. A lot of this code is
shared with inalloca, so catch this up to the others so that can
happen.
This commit is contained in:
Matt Arsenault
2021-03-06 13:23:57 -05:00
parent c5243c63cd
commit 4fefed6563
91 changed files with 447 additions and 265 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
View File

@@ -1624,6 +1624,8 @@ Error BitcodeReader::parseAttributeGroupBlock() {
B.addByValAttr(nullptr);
else if (Kind == Attribute::StructRet)
B.addStructRetAttr(nullptr);
else if (Kind == Attribute::InAlloca)
B.addInAllocaAttr(nullptr);
B.addAttribute(Kind);
} else if (Record[i] == 1) { // Integer attribute
@@ -1675,6 +1677,8 @@ Error BitcodeReader::parseAttributeGroupBlock() {
B.addByRefAttr(getTypeByID(Record[++i]));
} else if (Kind == Attribute::Preallocated) {
B.addPreallocatedAttr(getTypeByID(Record[++i]));
} else if (Kind == Attribute::InAlloca) {
B.addInAllocaAttr(HasType ? getTypeByID(Record[++i]) : nullptr);
}
}
}
@@ -3328,7 +3332,8 @@ Error BitcodeReader::parseFunctionRecord(ArrayRef<uint64_t> Record) {
// argument's pointee type. There should be no opaque pointers where the byval
// type is implicit.
for (unsigned i = 0; i != Func->arg_size(); ++i) {
for (Attribute::AttrKind Kind : {Attribute::ByVal, Attribute::StructRet}) {
for (Attribute::AttrKind Kind : {Attribute::ByVal, Attribute::StructRet,
Attribute::InAlloca}) {
if (!Func->hasParamAttribute(i, Kind))
continue;
@@ -3336,10 +3341,21 @@ Error BitcodeReader::parseFunctionRecord(ArrayRef<uint64_t> Record) {
Type *PTy = cast<FunctionType>(FullFTy)->getParamType(i);
Type *PtrEltTy = getPointerElementFlatType(PTy);
Attribute NewAttr =
Kind == Attribute::ByVal
? Attribute::getWithByValType(Context, PtrEltTy)
: Attribute::getWithStructRetType(Context, PtrEltTy);
Attribute NewAttr;
switch (Kind) {
case Attribute::ByVal:
NewAttr = Attribute::getWithByValType(Context, PtrEltTy);
break;
case Attribute::StructRet:
NewAttr = Attribute::getWithStructRetType(Context, PtrEltTy);
break;
case Attribute::InAlloca:
NewAttr = Attribute::getWithInAllocaType(Context, PtrEltTy);
break;
default:
llvm_unreachable("not an upgraded type attribute");
}
Func->addParamAttr(i, NewAttr);
}
}
@@ -3805,17 +3821,29 @@ Error BitcodeReader::typeCheckLoadStoreInst(Type *ValType, Type *PtrType) {
void BitcodeReader::propagateByValSRetTypes(CallBase *CB,
ArrayRef<Type *> ArgsFullTys) {
for (unsigned i = 0; i != CB->arg_size(); ++i) {
for (Attribute::AttrKind Kind : {Attribute::ByVal, Attribute::StructRet}) {
for (Attribute::AttrKind Kind : {Attribute::ByVal, Attribute::StructRet,
Attribute::InAlloca}) {
if (!CB->paramHasAttr(i, Kind))
continue;
CB->removeParamAttr(i, Kind);
Type *PtrEltTy = getPointerElementFlatType(ArgsFullTys[i]);
Attribute NewAttr =
Kind == Attribute::ByVal
? Attribute::getWithByValType(Context, PtrEltTy)
: Attribute::getWithStructRetType(Context, PtrEltTy);
Attribute NewAttr;
switch (Kind) {
case Attribute::ByVal:
NewAttr = Attribute::getWithByValType(Context, PtrEltTy);
break;
case Attribute::StructRet:
NewAttr = Attribute::getWithStructRetType(Context, PtrEltTy);
break;
case Attribute::InAlloca:
NewAttr = Attribute::getWithInAllocaType(Context, PtrEltTy);
break;
default:
llvm_unreachable("not an upgraded type attribute");
}
CB->addParamAttr(i, NewAttr);
}
}