caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Transforms] classifyArgUse - don't deference pointer before null test

Browse Source 
Reported here: https://pvs-studio.com/en/blog/posts/cpp/1003/ (N11)
This commit is contained in:
Simon Pilgrim
2022-10-25 17:23:25 +01:00
parent 60809cd293
commit 50fe87a5c8
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
View File

@@ -2621,9 +2621,7 @@ void LibCallSimplifier::classifyArgUse(
SmallVectorImpl<CallInst *> &SinCalls,
SmallVectorImpl<CallInst *> &CosCalls,
SmallVectorImpl<CallInst *> &SinCosCalls) {
CallInst *CI = dyn_cast<CallInst>(Val);
Module *M = CI->getModule();
auto *CI = dyn_cast<CallInst>(Val);
if (!CI || CI->use_empty())
return;
@@ -2631,6 +2629,7 @@ void LibCallSimplifier::classifyArgUse(
if (CI->getFunction() != F)
return;
Module *M = CI->getModule();
Function *Callee = CI->getCalledFunction();
LibFunc Func;
if (!Callee || !TLI->getLibFunc(*Callee, Func) ||