caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pipeline-invalid.mlir bytecode roundtrip test (#82366)

Browse Source 
If an op was not contained in a region when was written to bytecode,
we don't have an initialized valueScope with forward references to
define.
This commit is contained in:
Matteo Franciolini
2024-02-20 21:40:36 -08:00
committed by GitHub
parent a2afcd5721
commit 5375cbfb62
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mlir/lib/Bytecode/Reader/BytecodeReader.cpp
View File

@@ -2334,8 +2334,11 @@ BytecodeReader::Impl::parseOpWithoutRegions(EncodingReader &reader,
Operation *op = Operation::create(opState);
readState.curBlock->push_back(op);
// If the operation had results, update the value references.
if (op->getNumResults() && failed(defineValues(reader, op->getResults())))
// If the operation had results, update the value references. We don't need to
// do this if the current value scope is empty. That is, the op was not
// encoded within a parent region.
if (readState.numValues && op->getNumResults() &&
failed(defineValues(reader, op->getResults())))
return failure();
/// Store a map for every value that received a custom use-list order from the