caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery

Browse Source 
This is not meant to report that a value doesn't have a dynamic type - it is only meant as a mechanism to propagate actual type discovery issues (e.g. malformed type metadata for languages that have such a notion)

This information is used by ValueObjectDynamic to set its own m_error, which is a fairly sharp and heavyweight tool to begin with

For the time being, this is an architectural improvement but a practical no-op as no existing runtimes are actually setting errors

llvm-svn: 268591
This commit is contained in:
Enrico Granata
2016-05-05 01:47:44 +00:00
parent 8752be775c
commit 5ee5408625
16 changed files with 98 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/source/Plugins/LanguageRuntime/Java/JavaLanguageRuntime.cpp
View File

@@ -105,10 +105,14 @@ GetDynamicTypeId(ExecutionContext *exe_ctx, Target *target, ValueObject &in_valu
}
bool
JavaLanguageRuntime::GetDynamicTypeAndAddress(ValueObject &in_value, lldb::DynamicValueType use_dynamic,
TypeAndOrName &class_type_or_name, Address &dynamic_address,
Value::ValueType &value_type)
JavaLanguageRuntime::GetDynamicTypeAndAddress(ValueObject &in_value,
lldb::DynamicValueType use_dynamic,
TypeAndOrName &class_type_or_name,
Address &dynamic_address,
Value::ValueType &value_type,
Error &error)
{
error.Clear();
class_type_or_name.Clear();
// null references don't have a dynamic type