caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

<rdar://problem/12831670>

Browse Source 
When using the same-device optimization for shared cache libraries, if
we have an invalid load address for __LINKEDIT, don't try to read
anything out of lldb's own address space.  Reading it out of the remote
address space will fail gracefully if we have bad addresses but reading
it out of lldb's own address space will result in a crash.

llvm-svn: 169582
This commit is contained in:
Jason Molenda
2012-12-07 03:38:23 +00:00
parent b006d38476
commit 641de41cb4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
View File

@@ -1326,7 +1326,7 @@ ObjectFileMachO::ParseSymtab (bool minimize)
// data across can slow down debug launch times, so we optimize this by
// reading the memory for the __LINKEDIT section from this process.
PlatformSP platform_sp (target.GetPlatform());
if (platform_sp && platform_sp->IsHost())
if (platform_sp && platform_sp->IsHost() && linkedit_load_addr != LLDB_INVALID_ADDRESS)
{
data_was_read = true;
nlist_data.SetData((void *)symoff_addr, nlist_data_byte_size, eByteOrderLittle);