From 6d515ce8270ebeeaab771c7db08fbf9bf146e31d Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 18 May 2025 18:13:49 -0700 Subject: [PATCH] [mlir] Use llvm::all_of (NFC) (#140464) --- .../Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp | 18 ++++++++---------- .../Transforms/ExtractAddressComputations.cpp | 7 +++---- mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp | 5 ++--- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git a/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp b/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp index 6119097456d1..7a0a7f86bc1e 100644 --- a/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp +++ b/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp @@ -115,16 +115,14 @@ void mlir::configureOpenMPToLLVMConversionLegality( >([&](Operation *op) { return typeConverter.isLegal(op->getOperandTypes()) && typeConverter.isLegal(op->getResultTypes()) && - std::all_of(op->getRegions().begin(), op->getRegions().end(), - [&](Region ®ion) { - return typeConverter.isLegal(®ion); - }) && - std::all_of(op->getAttrs().begin(), op->getAttrs().end(), - [&](NamedAttribute attr) { - auto typeAttr = dyn_cast(attr.getValue()); - return !typeAttr || - typeConverter.isLegal(typeAttr.getValue()); - }); + llvm::all_of(op->getRegions(), + [&](Region ®ion) { + return typeConverter.isLegal(®ion); + }) && + llvm::all_of(op->getAttrs(), [&](NamedAttribute attr) { + auto typeAttr = dyn_cast(attr.getValue()); + return !typeAttr || typeConverter.isLegal(typeAttr.getValue()); + }); }); } diff --git a/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp b/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp index b906c727604d..723b4d01186f 100644 --- a/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp +++ b/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp @@ -251,10 +251,9 @@ struct LoadStoreLikeOpRewriter : public OpRewritePattern { // to do. SmallVector indices = getAsOpFoldResult(loadStoreLikeOp.getIndices()); - if (std::all_of(indices.begin(), indices.end(), - [](const OpFoldResult &opFold) { - return isConstantIntValue(opFold, 0); - })) { + if (llvm::all_of(indices, [](const OpFoldResult &opFold) { + return isConstantIntValue(opFold, 0); + })) { return rewriter.notifyMatchFailure( loadStoreLikeOp, "no computation to extract: offsets are 0s"); } diff --git a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp index c99e925a9763..0afc502c026f 100644 --- a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp +++ b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp @@ -312,9 +312,8 @@ LogicalResult LoadNdOp::verify() { auto trans = getTranspose().value(); // Make sure the transpose value is valid. - bool valid = std::all_of(trans.begin(), trans.end(), [&](int t) { - return t >= 0 && t < tdescTy.getRank(); - }); + bool valid = llvm::all_of( + trans, [&](int t) { return t >= 0 && t < tdescTy.getRank(); }); if (valid) transpose(trans, tdescShape);