caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Change return type of FileSpec::GetFileNameExtension

Browse Source 
These don't really need to be in ConstStrings. It's nice that comparing
ConstStrings is fast (just a pointer comparison) but the cost of
creating the ConstString usually already includes the cost of doing a
StringRef comparison anyway, so this is just extra work and extra memory
consumption for basically no benefit.

Differential Revision: https://reviews.llvm.org/D149300
This commit is contained in:
Alex Langford
2023-04-26 15:01:12 -07:00
parent 92f1156efc
commit 6fcdfc378c
10 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
View File

@@ -2029,7 +2029,7 @@ unsigned ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t start_id,
// contain the note section specifying the environment to Android but the
// custom extension and file name makes it highly unlikely that this will
// collide with anything else.
ConstString file_extension = m_file.GetFileNameExtension();
llvm::StringRef file_extension = m_file.GetFileNameExtension();
bool skip_oatdata_oatexec =
file_extension == ".oat" || file_extension == ".odex";