caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PDB/CodeView] Rename some classes.

Browse Source 
In preparation for introducing writing capabilities for each of
these classes, I would like to adopt a Foo / FooRef naming
convention, where Foo indicates that the class can manipulate and
serialize Foos, and FooRef indicates that it is an immutable view of
an existing Foo.  In other words, Foo is a writer and FooRef is a
reader.  This patch names some existing readers to conform to the
FooRef convention, while offering no functional change.

llvm-svn: 301810
This commit is contained in:
Zachary Turner
2017-05-01 16:46:39 +00:00
parent 8a6238201f
commit 7cc13e557c
18 changed files with 69 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
llvm/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp
View File

@@ -25,13 +25,14 @@ using namespace llvm::codeview;
using namespace llvm::msf;
using namespace llvm::pdb;
ModuleDebugStream::ModuleDebugStream(const DbiModuleDescriptor &Module,
std::unique_ptr<MappedBlockStream> Stream)
ModuleDebugStreamRef::ModuleDebugStreamRef(
const DbiModuleDescriptor &Module,
std::unique_ptr<MappedBlockStream> Stream)
: Mod(Module), Stream(std::move(Stream)) {}
ModuleDebugStream::~ModuleDebugStream() = default;
ModuleDebugStreamRef::~ModuleDebugStreamRef() = default;
Error ModuleDebugStream::reload() {
Error ModuleDebugStreamRef::reload() {
BinaryStreamReader Reader(*Stream);
uint32_t SymbolSize = Mod.getSymbolDebugInfoByteSize();
@@ -49,7 +50,7 @@ Error ModuleDebugStream::reload() {
if (auto EC = Reader.readArray(SymbolsSubstream, SymbolSize - 4))
return EC;
if (auto EC = Reader.readStreamRef(LinesSubstream, C11Size))
if (auto EC = Reader.readStreamRef(C11LinesSubstream, C11Size))
return EC;
if (auto EC = Reader.readStreamRef(C13LinesSubstream, C13Size))
return EC;
@@ -72,17 +73,17 @@ Error ModuleDebugStream::reload() {
}
iterator_range<codeview::CVSymbolArray::Iterator>
ModuleDebugStream::symbols(bool *HadError) const {
ModuleDebugStreamRef::symbols(bool *HadError) const {
return make_range(SymbolsSubstream.begin(HadError), SymbolsSubstream.end());
}
llvm::iterator_range<ModuleDebugStream::LinesAndChecksumsIterator>
ModuleDebugStream::linesAndChecksums() const {
llvm::iterator_range<ModuleDebugStreamRef::LinesAndChecksumsIterator>
ModuleDebugStreamRef::linesAndChecksums() const {
return make_range(LinesAndChecksums.begin(), LinesAndChecksums.end());
}
bool ModuleDebugStream::hasLineInfo() const {
bool ModuleDebugStreamRef::hasLineInfo() const {
return C13LinesSubstream.getLength() > 0;
}
Error ModuleDebugStream::commit() { return Error::success(); }
Error ModuleDebugStreamRef::commit() { return Error::success(); }