caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Clarify StructuredDataImpl ownership

Browse Source 
StructuredDataImpl ownership semantics is unclear at best. Various
structures were holding a non-owning pointer to it, with a comment that
the object is owned somewhere else. From what I was able to gather that
"somewhere else" was the SBStructuredData object, but I am not sure that
all created object eventually made its way there. (It wouldn't matter
even if they did, as we are leaking most of our SBStructuredData
objects.)

Since StructuredDataImpl is just a collection of two (shared) pointers,
there's really no point in elaborate lifetime management, so this patch
replaces all StructuredDataImpl pointers with actual objects or
unique_ptrs to it. This makes it much easier to resolve SBStructuredData
leaks in a follow-up patch.

Differential Revision: https://reviews.llvm.org/D114791
This commit is contained in:
Pavel Labath
2021-11-25 14:01:41 +01:00
parent 34696e6542
commit 82de8df26f
24 changed files with 103 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h
View File

@@ -33,13 +33,12 @@ public:
CommandDataPython() : BreakpointOptions::CommandData() {
interpreter = lldb::eScriptLanguagePython;
}
CommandDataPython(StructuredData::ObjectSP extra_args_sp) :
BreakpointOptions::CommandData(),
m_extra_args_up(new StructuredDataImpl()) {
interpreter = lldb::eScriptLanguagePython;
m_extra_args_up->SetObjectSP(extra_args_sp);
CommandDataPython(StructuredData::ObjectSP extra_args_sp)
: BreakpointOptions::CommandData(),
m_extra_args(std::move(extra_args_sp)) {
interpreter = lldb::eScriptLanguagePython;
}
lldb::StructuredDataImplUP m_extra_args_up;
StructuredDataImpl m_extra_args;
};
ScriptInterpreterPython(Debugger &debugger)