[lldb] Remove outdated comment and radar link (NFC)
The comment and radar referenced PyThreadState_Get which is no longer used there and instead has been replaced to a call to PyThreadState_GetDict which has different semantics. Unlike PyThreadState_Get, it can return NULL and it is okay to call this function when no current thread state is available.
This commit is contained in:
@@ -582,10 +582,6 @@ void ScriptInterpreterPythonImpl::LeaveSession() {
|
||||
// up believing we have no thread state and PyImport_AddModule will crash if
|
||||
// that is the case - since that seems to only happen when destroying the
|
||||
// SBDebugger, we can make do without clearing up stdout and stderr
|
||||
|
||||
// rdar://problem/11292882
|
||||
// When the current thread state is NULL, PyThreadState_Get() issues a fatal
|
||||
// error.
|
||||
if (PyThreadState_GetDict()) {
|
||||
PythonDictionary &sys_module_dict = GetSysModuleDictionary();
|
||||
if (sys_module_dict.IsValid()) {
|
||||
@@ -1783,7 +1779,7 @@ lldb::StateType ScriptInterpreterPythonImpl::ScriptedThreadPlanGetRunState(
|
||||
|
||||
bool
|
||||
ScriptInterpreterPythonImpl::ScriptedThreadPlanGetStopDescription(
|
||||
StructuredData::ObjectSP implementor_sp, lldb_private::Stream *stream,
|
||||
StructuredData::ObjectSP implementor_sp, lldb_private::Stream *stream,
|
||||
bool &script_error) {
|
||||
StructuredData::Generic *generic = nullptr;
|
||||
if (implementor_sp)
|
||||
|
||||
Reference in New Issue
Block a user