caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

Browse Source 
Currently SBTarget::LaunchSimple creates a new LaunchInfo which means it
ignores any target properties that have been set. Instead, it should
start from the target's LaunchInfo and populated the specified fields.

Differential revision: https://reviews.llvm.org/D85235
This commit is contained in:
Jonas Devlieghere
2020-08-05 09:34:18 -07:00
parent 3169d920cc
commit 882d8e60dd
3 changed files with 60 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lldb/source/API/SBTarget.cpp
View File

@@ -287,16 +287,24 @@ SBProcess SBTarget::LaunchSimple(char const **argv, char const **envp,
(const char **, const char **, const char *), argv, envp,
working_directory);
char *stdin_path = nullptr;
char *stdout_path = nullptr;
char *stderr_path = nullptr;
uint32_t launch_flags = 0;
bool stop_at_entry = false;
TargetSP target_sp = GetSP();
if (!target_sp)
return LLDB_RECORD_RESULT(SBProcess());
SBLaunchInfo launch_info = GetLaunchInfo();
if (Module *exe_module = target_sp->GetExecutableModulePointer())
launch_info.SetExecutableFile(exe_module->GetPlatformFileSpec(),
/*add_as_first_arg*/ true);
if (argv)
launch_info.SetArguments(argv, /*append*/ true);
if (envp)
launch_info.SetEnvironmentEntries(envp, /*append*/ false);
if (working_directory)
launch_info.SetWorkingDirectory(working_directory);
SBError error;
SBListener listener = GetDebugger().GetListener();
return LLDB_RECORD_RESULT(Launch(listener, argv, envp, stdin_path,
stdout_path, stderr_path, working_directory,
launch_flags, stop_at_entry, error));
return LLDB_RECORD_RESULT(Launch(launch_info, error));
}
SBError SBTarget::Install() {