caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Parse the crashlog only once

Browse Source 
Now that we can pass Python objects to the scripted process instance, we
don't need to parse the crashlog twice anymore.

Differential revision: https://reviews.llvm.org/D148063
This commit is contained in:
Jonas Devlieghere
2023-04-11 17:03:49 -07:00
parent 9d701c8a8d
commit 88f409194d
4 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
lldb/examples/python/scripted_process/crashlog_scripted_process.py
View File

@@ -9,20 +9,18 @@ from lldb.plugins.scripted_process import ScriptedThread
from lldb.macosx.crashlog import CrashLog,CrashLogParser
class CrashLogScriptedProcess(ScriptedProcess):
def parse_crashlog(self):
crashlog_parser = CrashLogParser.create(self.dbg, self.crashlog_path, False)
crash_log = crashlog_parser.parse()
self.pid = crash_log.process_id
self.addr_mask = crash_log.addr_mask
self.crashed_thread_idx = crash_log.crashed_thread_idx
def set_crashlog(self, crashlog):
self.crashlog = crashlog
self.pid = self.crashlog.process_id
self.addr_mask = self.crashlog.addr_mask
self.crashed_thread_idx = self.crashlog.crashed_thread_idx
self.loaded_images = []
self.exception = crash_log.exception
self.exception = self.crashlog.exception
self.app_specific_thread = None
if hasattr(crash_log, 'asi'):
self.metadata['asi'] = crash_log.asi
if hasattr(crash_log, 'asb'):
self.extended_thread_info = crash_log.asb
if hasattr(self.crashlog, 'asi'):
self.metadata['asi'] = self.crashlog.asi
if hasattr(self.crashlog, 'asb'):
self.extended_thread_info = self.crashlog.asb
def load_images(self, images):
#TODO: Add to self.loaded_images and load images in lldb
@@ -38,12 +36,12 @@ class CrashLogScriptedProcess(ScriptedProcess):
else:
self.loaded_images.append(image)
for thread in crash_log.threads:
for thread in self.crashlog.threads:
if self.load_all_images:
load_images(self, crash_log.images)
load_images(self, self.crashlog.images)
elif thread.did_crash():
for ident in thread.idents:
load_images(self, crash_log.find_images_with_identifier(ident))
load_images(self, self.crashlog.find_images_with_identifier(ident))
if hasattr(thread, 'app_specific_backtrace') and thread.app_specific_backtrace:
# We don't want to include the Application Specific Backtrace
@@ -92,7 +90,6 @@ class CrashLogScriptedProcess(ScriptedProcess):
self.crashed_thread_idx = 0
self.exception = None
self.extended_thread_info = None
self.parse_crashlog()
def read_memory_at_address(self, addr: int, size: int, error: lldb.SBError) -> lldb.SBData:
# NOTE: CrashLogs don't contain any memory.