caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[LLD] [COFF] Print a warning when using /dependentloadflag without load config (#117400)

Browse Source 
As per request in https://github.com/llvm/llvm-project/pull/113814.
This commit is contained in:
Mateusz Mikuła
2024-12-05 21:28:38 +01:00
committed by GitHub
parent c54616ea48
commit 8a6f1abe16
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lld/COFF/Writer.cpp
View File

@@ -2654,6 +2654,9 @@ void Writer::prepareLoadConfig() {
if (ctx.config.guardCF != GuardCFLevel::Off)
Warn(ctx)
<< "Control Flow Guard is enabled but '_load_config_used' is missing";
if (ctx.config.dependentLoadFlags)
Warn(ctx) << "_load_config_used not found, /dependentloadflag will have "
"no effect";
return;
}

6
lld/test/COFF/dependentflags.test
View File

@@ -20,6 +20,10 @@ RUN: not lld-link %S/Inputs/precomp-a.obj %t.ldcfg.obj /out:%t.exe /nodefaultlib
RUN: not lld-link %S/Inputs/precomp-a.obj %t.ldcfg.obj /out:%t.exe /nodefaultlib /force /dependentloadflag:zz 2>&1 | FileCheck %s --check-prefix FAIL
RUN: not lld-link %S/Inputs/precomp-a.obj %t.ldcfg.obj /out:%t.exe /nodefaultlib /force /dependentloadflag:0xf0000 2>&1 | FileCheck %s --check-prefix FAIL-RANGE
// ---- Warn if _load_config_used is missing
RUN: llvm-lib %t.ldcfg.obj /out:%t.lib
RUN: lld-link %S/Inputs/precomp-a.obj /out:%t.exe /nodefaultlib /force /dependentloadflag:0x800 2>&1 | FileCheck %s --check-prefix WARN-NOBASE
RUN: lld-link %S/Inputs/precomp-a.obj %t.lib /out:%t.exe /nodefaultlib /force /dependentloadflag:0x800 2>&1 | FileCheck %s --allow-empty --check-prefix NO-WARN
BASE: DependentLoadFlags: 0x0
FLAGS-800: DependentLoadFlags: 0x800
@@ -29,3 +33,5 @@ FAIL: lld-link: error: /dependentloadflag: invalid argument: zz
FAIL-RANGE: lld-link: error: /dependentloadflag: invalid argument: 0xf0000
FAIL-NOARG: lld-link: error: /dependentloadflag: no argument specified
WARN-NOBASE: lld-link: warning: _load_config_used not found, /dependentloadflag will have no effect
NO-WARN-NOT: lld-link: warning: _load_config_used not found, /dependentloadflag will have no effect