caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[InferAlignment][NFC] Unify Load/Store handling in tryToImproveAlign (#112699)

Browse Source 
Removes code duplication in tryToImproveAlign by unifying load and
store instruction handling with getLoadStore helper functions.
This commit is contained in:
hanbeom
2024-10-17 22:47:37 +09:00
committed by GitHub
parent f9d0789064
commit 8c60efe94b
2 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/include/llvm/IR/Instructions.h
View File

@@ -4960,6 +4960,16 @@ inline Align getLoadStoreAlignment(const Value *I) {
return cast<StoreInst>(I)->getAlign();
}
/// A helper function that set the alignment of load or store instruction.
inline void setLoadStoreAlignment(Value *I, Align NewAlign) {
assert((isa<LoadInst>(I) || isa<StoreInst>(I)) &&
"Expected Load or Store instruction");
if (auto *LI = dyn_cast<LoadInst>(I))
LI->setAlignment(NewAlign);
else
cast<StoreInst>(I)->setAlignment(NewAlign);
}
/// A helper function that returns the address space of the pointer operand of
/// load or store instruction.
inline unsigned getLoadStoreAddressSpace(const Value *I) {

21
llvm/lib/Transforms/Scalar/InferAlignment.cpp
View File

@@ -25,21 +25,14 @@ using namespace llvm;
static bool tryToImproveAlign(
const DataLayout &DL, Instruction *I,
function_ref<Align(Value *PtrOp, Align OldAlign, Align PrefAlign)> Fn) {
if (auto *LI = dyn_cast<LoadInst>(I)) {
Value *PtrOp = LI->getPointerOperand();
Align OldAlign = LI->getAlign();
Align NewAlign = Fn(PtrOp, OldAlign, DL.getPrefTypeAlign(LI->getType()));
if (auto *PtrOp = getLoadStorePointerOperand(I)) {
Align OldAlign = getLoadStoreAlignment(I);
Align PrefAlign = DL.getPrefTypeAlign(getLoadStoreType(I));
Align NewAlign = Fn(PtrOp, OldAlign, PrefAlign);
if (NewAlign > OldAlign) {
LI->setAlignment(NewAlign);
return true;
}
} else if (auto *SI = dyn_cast<StoreInst>(I)) {
Value *PtrOp = SI->getPointerOperand();
Value *ValOp = SI->getValueOperand();
Align OldAlign = SI->getAlign();
Align NewAlign = Fn(PtrOp, OldAlign, DL.getPrefTypeAlign(ValOp->getType()));
if (NewAlign > OldAlign) {
SI->setAlignment(NewAlign);
setLoadStoreAlignment(I, NewAlign);
return true;
}
}