From 8cd628f4729814975656121a39417b8b4843a0a3 Mon Sep 17 00:00:00 2001 From: kevkevin Date: Fri, 25 Apr 2025 16:51:10 -0500 Subject: [PATCH] doc: get rid of redundant TODO tag in FuzzedDataProvider.h (#137395) 'list.size()' is determined at runtime, so using static_assert on it as suggested by the TODO comment is not feasible and produces the following error when done: error: static assertion expression is not an integral constant expression initially referenced in https://github.com/bitcoin/bitcoin/pull/32024 Co-authored-by: Chand-ra --- compiler-rt/include/fuzzer/FuzzedDataProvider.h | 1 - 1 file changed, 1 deletion(-) diff --git a/compiler-rt/include/fuzzer/FuzzedDataProvider.h b/compiler-rt/include/fuzzer/FuzzedDataProvider.h index 11f2fbdb8c85..33ffa8bc00bf 100644 --- a/compiler-rt/include/fuzzer/FuzzedDataProvider.h +++ b/compiler-rt/include/fuzzer/FuzzedDataProvider.h @@ -314,7 +314,6 @@ T FuzzedDataProvider::PickValueInArray(const std::array &array) { template T FuzzedDataProvider::PickValueInArray(std::initializer_list list) { - // TODO(Dor1s): switch to static_assert once C++14 is allowed. if (!list.size()) abort();