diff --git a/lldb/scripts/convert-lldb-header-to-rpc-header.py b/lldb/scripts/convert-lldb-header-to-rpc-header.py index d7734280076f..13b6bed20f77 100755 --- a/lldb/scripts/convert-lldb-header-to-rpc-header.py +++ b/lldb/scripts/convert-lldb-header-to-rpc-header.py @@ -27,7 +27,7 @@ LLDB_LOCAL_INCLUDE_REGEX = re.compile(r'#include "lldb/lldb-\s*', re.M) LLDB_NAMESPACE_DEFINITION_REGEX = re.compile( r"(?P//\s*){,1}namespace lldb\s{1}", re.M ) -LLDB_NAMESPACE_REGEX = re.compile(r"\s*.+lldb::\s*", re.M) +LLDB_NAMESPACE_REGEX = re.compile(r"lldb::\s*", re.M) def main(): diff --git a/lldb/test/Shell/RPC/Scripts/TestConvertScript/CheckLLDBEnumerations.test b/lldb/test/Shell/RPC/Scripts/TestConvertScript/CheckLLDBEnumerations.test index 0fb3c6f73dd0..1109086cf731 100644 --- a/lldb/test/Shell/RPC/Scripts/TestConvertScript/CheckLLDBEnumerations.test +++ b/lldb/test/Shell/RPC/Scripts/TestConvertScript/CheckLLDBEnumerations.test @@ -13,5 +13,8 @@ CHECK: #define LLDB_RPC_ENUMERATIONS_H # Change the namespace to lldb_rpc. Also, the comment that closes the namespace should match the namespace. CHECK: namespace lldb_rpc {} // namespace lldb_rpc +# When the lldb namespace is used, the namespace must be replaced with lldb_rpc. +CHECK: void dummyFunction(lldb_rpc::addr_t) {} + # The comment that closes the include guard should match the guard. CHECK: #endif // LLDB_RPC_ENUMERATIONS_H diff --git a/lldb/test/Shell/RPC/Scripts/TestConvertScript/Inputs/lldb-enumerations.h b/lldb/test/Shell/RPC/Scripts/TestConvertScript/Inputs/lldb-enumerations.h index 42c4bb277fc4..22dd09097d43 100644 --- a/lldb/test/Shell/RPC/Scripts/TestConvertScript/Inputs/lldb-enumerations.h +++ b/lldb/test/Shell/RPC/Scripts/TestConvertScript/Inputs/lldb-enumerations.h @@ -11,6 +11,9 @@ // namespace lldb -> namespace lldb_rpc namespace lldb {} // namespace lldb +// When the lldb namespace is used, the namespace must be replaced with lldb_rpc. +void dummyFunction(lldb::addr_t) {} + // The comment that closes the include guard must change in the same way // the original guard did: // #endif // LLDB_LLDB_ENUMERATIONS_H -> #endif // LLDB_RPC_ENUMERATIONS_H