[lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback
Summary: The SearchCallback has a bool parameter that we always set to false, we never use in any callback implementation and that also changes its name from one file to the other (either `containing` and `complete`). It was added in the original LLDB check in, so there isn't any history what this was supposed to be, so let's just remove it. Reviewers: jingham, JDevlieghere, labath Reviewed By: jingham, labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68696 llvm-svn: 374313
This commit is contained in:
@@ -790,7 +790,7 @@ RenderScriptRuntime::CreateInstance(Process *process,
|
||||
// symbol.
|
||||
Searcher::CallbackReturn
|
||||
RSBreakpointResolver::SearchCallback(SearchFilter &filter,
|
||||
SymbolContext &context, Address *, bool) {
|
||||
SymbolContext &context, Address *) {
|
||||
ModuleSP module = context.module_sp;
|
||||
|
||||
if (!module || !IsRenderScriptScriptModule(module))
|
||||
@@ -820,7 +820,7 @@ RSBreakpointResolver::SearchCallback(SearchFilter &filter,
|
||||
Searcher::CallbackReturn
|
||||
RSReduceBreakpointResolver::SearchCallback(lldb_private::SearchFilter &filter,
|
||||
lldb_private::SymbolContext &context,
|
||||
Address *, bool) {
|
||||
Address *) {
|
||||
// We need to have access to the list of reductions currently parsed, as
|
||||
// reduce names don't actually exist as symbols in a module. They are only
|
||||
// identifiable by parsing the .rs.info packet, or finding the expand symbol.
|
||||
@@ -880,8 +880,7 @@ RSReduceBreakpointResolver::SearchCallback(lldb_private::SearchFilter &filter,
|
||||
}
|
||||
|
||||
Searcher::CallbackReturn RSScriptGroupBreakpointResolver::SearchCallback(
|
||||
SearchFilter &filter, SymbolContext &context, Address *addr,
|
||||
bool containing) {
|
||||
SearchFilter &filter, SymbolContext &context, Address *addr) {
|
||||
|
||||
if (!m_breakpoint)
|
||||
return eCallbackReturnContinue;
|
||||
|
||||
Reference in New Issue
Block a user