From 96a5aabbd6adada4525d5e0107e96e6f57dbdfbf Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 4 Sep 2024 20:22:27 -0700 Subject: [PATCH] [NFC][sanitizer] Thread safety annotation for Symbolizer --- compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h index 16ef2f2fd717..bd89dc4e302f 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h +++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h @@ -185,17 +185,17 @@ class Symbolizer final { class ModuleNameOwner { public: explicit ModuleNameOwner(Mutex *synchronized_by) - : last_match_(nullptr), mu_(synchronized_by) { + : mu_(synchronized_by), last_match_(nullptr) { storage_.reserve(kInitialCapacity); } const char *GetOwnedCopy(const char *str); private: static const uptr kInitialCapacity = 1000; - InternalMmapVector storage_; - const char *last_match_; Mutex *mu_; + const char *last_match_ SANITIZER_GUARDED_BY(mu_); + InternalMmapVector storage_ SANITIZER_GUARDED_BY(*mu_); } module_names_; /// Platform-specific function for creating a Symbolizer object. @@ -220,7 +220,7 @@ class Symbolizer final { // always synchronized. Mutex mu_; - IntrusiveList tools_; + IntrusiveList tools_ SANITIZER_GUARDED_BY(mu_); explicit Symbolizer(IntrusiveList tools);