caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement ObjectFileELF::GetBaseAddress

Browse Source 
Summary:
The concept of a base address was already present in the implementation
(it's needed for computing section load addresses properly), but it was
never exposed through this function. This fixes that.

llvm-svn: 350804
This commit is contained in:
Pavel Labath
2019-01-10 09:32:31 +00:00
parent 8f85b9f867
commit 976af43ba9
5 changed files with 50 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
View File

@@ -806,17 +806,10 @@ bool ObjectFileELF::SetLoadAddress(Target &target, lldb::addr_t value,
SectionList *section_list = GetSectionList();
if (section_list) {
if (!value_is_offset) {
bool found_offset = false;
for (const ELFProgramHeader &H : ProgramHeaders()) {
if (H.p_type != PT_LOAD || H.p_offset != 0)
continue;
value = value - H.p_vaddr;
found_offset = true;
break;
}
if (!found_offset)
addr_t base = GetBaseAddress().GetFileAddress();
if (base == LLDB_INVALID_ADDRESS)
return false;
value -= base;
}
const size_t num_sections = section_list->GetSize();
@@ -1055,6 +1048,18 @@ lldb_private::Address ObjectFileELF::GetEntryPointAddress() {
return m_entry_point_address;
}
Address ObjectFileELF::GetBaseAddress() {
for (const auto &EnumPHdr : llvm::enumerate(ProgramHeaders())) {
const ELFProgramHeader &H = EnumPHdr.value();
if (H.p_type != PT_LOAD || H.p_offset != 0)
continue;
return Address(
GetSectionList()->FindSectionByID(SegmentID(EnumPHdr.index())), 0);
}
return LLDB_INVALID_ADDRESS;
}
//----------------------------------------------------------------------
// ParseDependentModules
//----------------------------------------------------------------------