From a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 18 Oct 2024 10:40:13 -0700 Subject: [PATCH] [lldb] Avoid repeated map lookups (NFC) (#112823) --- lldb/source/Commands/CommandObjectMultiword.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lldb/source/Commands/CommandObjectMultiword.cpp b/lldb/source/Commands/CommandObjectMultiword.cpp index 484d9022027e..b4cdfea9b1a3 100644 --- a/lldb/source/Commands/CommandObjectMultiword.cpp +++ b/lldb/source/Commands/CommandObjectMultiword.cpp @@ -102,11 +102,9 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand( std::string str_name(name); - auto pos = m_subcommand_dict.find(str_name); - if (pos == m_subcommand_dict.end()) { - m_subcommand_dict[str_name] = cmd_obj_sp; + auto [pos, inserted] = m_subcommand_dict.try_emplace(str_name, cmd_obj_sp); + if (inserted) return llvm::Error::success(); - } const char *error_str = nullptr; if (!can_replace) @@ -117,7 +115,7 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand( if (error_str) { return llvm::createStringError(llvm::inconvertibleErrorCode(), error_str); } - m_subcommand_dict[str_name] = cmd_obj_sp; + pos->second = cmd_obj_sp; return llvm::Error::success(); }