caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make lldb -Werror clean for -Wstring-conversion

Browse Source 
Also found/fixed one bug identified by this warning in
RenderScriptx86ABIFixups.cpp where a string literal was being used in an
effort to provide a name for an instruction/register, but was instead
being passed as the bool 'isVolatile' parameter.

llvm-svn: 291198
This commit is contained in:
David Blaikie
2017-01-06 00:38:06 +00:00
parent 049b017538
commit a322f36cfd
26 changed files with 66 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lldb/tools/debugserver/source/DNBDataRef.cpp
View File

@@ -115,18 +115,13 @@ uint32_t DNBDataRef::GetMax32(offset_t *offset_ptr, uint32_t byte_size) const {
switch (byte_size) {
case 1:
return Get8(offset_ptr);
break;
case 2:
return Get16(offset_ptr);
break;
case 4:
return Get32(offset_ptr);
break;
default:
assert(!"GetMax32 unhandled case!");
break;
llvm_unreachable("GetMax32 unhandled case!");
}
return 0;
}
//----------------------------------------------------------------------
@@ -139,21 +134,15 @@ uint64_t DNBDataRef::GetMax64(offset_t *offset_ptr, uint32_t size) const {
switch (size) {
case 1:
return Get8(offset_ptr);
break;
case 2:
return Get16(offset_ptr);
break;
case 4:
return Get32(offset_ptr);
break;
case 8:
return Get64(offset_ptr);
break;
default:
assert(!"GetMax64 unhandled case!");
break;
llvm_unreachable("GetMax64 unhandled case!");
}
return 0;
}
//----------------------------------------------------------------------