Revert "Return a named error in the result object of an expression with no result"

This reverts commit r344647.
This causes build failures with [-Werror, -Wswitch]. Some cases where the newly
introduced enum value is not handled in particular are in:
  lldb/source/Expression/REPL.cpp:350
  lldb/source/Interpreter/CommandInterpreter.cpp:1529
(maybe there could be more)

As I don't understand lldb to make sure the likely trivial fixes are
correct and also as they might need additional tests, leaving to the
author to resolve.

llvm-svn: 344722
This commit is contained in:
Krasimir Georgiev
2018-10-18 03:10:43 +00:00
parent 11bc3a18e2
commit a35912da9f
10 changed files with 11 additions and 73 deletions

View File

@@ -1758,7 +1758,7 @@ bool RenderScriptRuntime::EvalRSExpression(const char *expr,
if (!expr_result->GetError().Success()) {
Status err = expr_result->GetError();
// Expression returned is void, so this is actually a success
if (err.GetError() == lldb::eExpressionProducedNoResult) {
if (err.GetError() == UserExpression::kNoResult) {
if (log)
log->Printf("%s - expression returned void.", __FUNCTION__);