caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Return StringRef from PluginInterface::GetPluginName

Browse Source 
There is no reason why this function should be returning a ConstString.

While modifying these files, I also fixed several instances where
GetPluginName and GetPluginNameStatic were returning different strings.

I am not changing the return type of GetPluginNameStatic in this patch, as that
would necessitate additional changes, and this patch is big enough as it is.

Differential Revision: https://reviews.llvm.org/D111877
This commit is contained in:
Pavel Labath
2021-10-15 13:07:39 +02:00
parent de4d2f80b7
commit a3939e159f
205 changed files with 468 additions and 687 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/source/API/SBProcess.cpp
View File

@@ -88,7 +88,7 @@ const char *SBProcess::GetPluginName() {
ProcessSP process_sp(GetSP());
if (process_sp) {
return process_sp->GetPluginName().GetCString();
return ConstString(process_sp->GetPluginName()).GetCString();
}
return "<Unknown>";
}
@@ -98,7 +98,7 @@ const char *SBProcess::GetShortPluginName() {
ProcessSP process_sp(GetSP());
if (process_sp) {
return process_sp->GetPluginName().GetCString();
return ConstString(process_sp->GetPluginName()).GetCString();
}
return "<Unknown>";
}