caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb/Module] Allow for the creation of memory-only modules

Browse Source 
Summary:
This patch extends the ModuleSpec class to include a
DataBufferSP which contains the module data. If this
data is provided, LLDB won't try to hit the filesystem
to create the Module, but use only the data stored in
the ModuleSpec.

Reviewers: labath, espindola

Subscribers: emaste, MaskRay, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D83512
This commit is contained in:
Fred Riss
2020-07-09 14:14:36 -07:00
parent 706cccb889
commit a4a00ced0c
17 changed files with 293 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
View File

@@ -169,8 +169,9 @@ size_t ObjectFilePECOFF::GetModuleSpecifications(
Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
if (DataBufferSP full_sp = MapFileData(file, -1, file_offset))
data_sp = std::move(full_sp);
if (data_sp->GetByteSize() < length)
if (DataBufferSP full_sp = MapFileData(file, -1, file_offset))
data_sp = std::move(full_sp);
auto binary = llvm::object::createBinary(llvm::MemoryBufferRef(
toStringRef(data_sp->GetData()), file.GetFilename().GetStringRef()));
@@ -539,6 +540,9 @@ DataExtractor ObjectFilePECOFF::ReadImageData(uint32_t offset, size_t size) {
if (!size)
return {};
if (m_data.ValidOffsetForDataOfSize(offset, size))
return DataExtractor(m_data, offset, size);
if (m_file) {
// A bit of a hack, but we intend to write to this buffer, so we can't
// mmap it.
@@ -562,13 +566,11 @@ DataExtractor ObjectFilePECOFF::ReadImageData(uint32_t offset, size_t size) {
}
DataExtractor ObjectFilePECOFF::ReadImageDataByRVA(uint32_t rva, size_t size) {
if (m_file) {
Address addr = GetAddress(rva);
SectionSP sect = addr.GetSection();
if (!sect)
return {};
rva = sect->GetFileOffset() + addr.GetOffset();
}
Address addr = GetAddress(rva);
SectionSP sect = addr.GetSection();
if (!sect)
return {};
rva = sect->GetFileOffset() + addr.GetOffset();
return ReadImageData(rva, size);
}