caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Watchpoints remember the type of the expression or variable they were set with, and use

Browse Source 
it to print the old and new values.
Temporarily disable the "out of scope" checking since it didn't work correctly, and was
not what people generally expected watchpoints to be doing.  

llvm-svn: 166472
This commit is contained in:
Jim Ingham
2012-10-23 07:20:06 +00:00
parent 0a08aa91d5
commit a7dfb665e3
12 changed files with 109 additions and 200 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/source/API/SBTarget.cpp
View File

@@ -1783,7 +1783,9 @@ SBTarget::WatchAddress (lldb::addr_t addr, size_t size, bool read, bool write, S
watch_type |= LLDB_WATCH_TYPE_WRITE;
// Target::CreateWatchpoint() is thread safe.
Error cw_error;
watchpoint_sp = target_sp->CreateWatchpoint(addr, size, watch_type, cw_error);
// This API doesn't take in a type, so we can't figure out what it is.
ClangASTType *type = NULL;
watchpoint_sp = target_sp->CreateWatchpoint(addr, size, type, watch_type, cw_error);
error.SetError(cw_error);
sb_watchpoint.SetSP (watchpoint_sp);
}