Make llvm::StringRef to std::string conversions explicit.
This is how it should've been and brings it more in line with std::string_view. There should be no functional change here. This is mostly mechanical from a custom clang-tidy check, with a lot of manual fixups. It uncovers a lot of minor inefficiencies. This doesn't actually modify StringRef yet, I'll do that in a follow-up.
This commit is contained in:
@@ -853,7 +853,7 @@ static std::string GenerateUniqueName(const char *base_name_wanted,
|
||||
else
|
||||
sstr.Printf("%s_%p", base_name_wanted, name_token);
|
||||
|
||||
return sstr.GetString();
|
||||
return std::string(sstr.GetString());
|
||||
}
|
||||
|
||||
bool ScriptInterpreterPythonImpl::GetEmbeddedInterpreterModuleObjects() {
|
||||
@@ -3035,7 +3035,7 @@ bool ScriptInterpreterPythonImpl::GetDocumentationForItem(const char *item,
|
||||
StreamString str_stream;
|
||||
str_stream.Printf(
|
||||
"Function %s was not found. Containing module might be missing.", item);
|
||||
dest = str_stream.GetString();
|
||||
dest = std::string(str_stream.GetString());
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user