caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't cache the public stop reason, since it can change as plan completion gets processed. That means GetStopReason needs to return a shared pointer, not a pointer to the thread's cached version. Also allow the thread plans to get and set the thread private stop reason - that is usually more appropriate for the logic the thread plans need to do.

Browse Source 
llvm-svn: 116892
This commit is contained in:
Jim Ingham
2010-10-20 00:39:53 +00:00
parent 20f7ab72b1
commit b15bfc753c
15 changed files with 78 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lldb/source/API/SBThread.cpp
View File

@@ -81,9 +81,9 @@ SBThread::GetStopReason()
{
if (m_opaque_sp)
{
lldb_private::StopInfo *stop_info = m_opaque_sp->GetStopInfo ();
if (stop_info)
return stop_info->GetStopReason();
StopInfoSP stop_info_sp = m_opaque_sp->GetStopInfo ();
if (stop_info_sp)
return stop_info_sp->GetStopReason();
}
return eStopReasonInvalid;
}
@@ -93,10 +93,10 @@ SBThread::GetStopDescription (char *dst, size_t dst_len)
{
if (m_opaque_sp)
{
lldb_private::StopInfo *stop_info = m_opaque_sp->GetStopInfo ();
if (stop_info)
StopInfoSP stop_info_sp = m_opaque_sp->GetStopInfo ();
if (stop_info_sp)
{
const char *stop_desc = stop_info->GetDescription();
const char *stop_desc = stop_info_sp->GetDescription();
if (stop_desc)
{
if (dst)
@@ -110,7 +110,7 @@ SBThread::GetStopDescription (char *dst, size_t dst_len)
else
{
size_t stop_desc_len = 0;
switch (stop_info->GetStopReason())
switch (stop_info_sp->GetStopReason())
{
case eStopReasonTrace:
case eStopReasonPlanComplete:
@@ -139,7 +139,7 @@ SBThread::GetStopDescription (char *dst, size_t dst_len)
case eStopReasonSignal:
{
stop_desc = m_opaque_sp->GetProcess().GetUnixSignals ().GetSignalAsCString (stop_info->GetValue());
stop_desc = m_opaque_sp->GetProcess().GetUnixSignals ().GetSignalAsCString (stop_info_sp->GetValue());
if (stop_desc == NULL || stop_desc[0] == '\0')
{
static char signal_desc[] = "signal";