caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb/Test] Add a trace method to replace print statements.

Browse Source 
Many tests use (commented out) print statement for debugging the test
itself. This patch adds a new trace method to lldbtest to reuse the
existing tracing infrastructure and replace these print statements.

Differential revision: https://reviews.llvm.org/D80448
This commit is contained in:
Jonas Devlieghere
2020-05-25 10:59:39 -07:00
parent 5bf2409a4e
commit b321b42941
23 changed files with 136 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lldb/test/API/python_api/function_symbol/TestDisasmAPI.py
View File

@@ -38,8 +38,8 @@ class DisasmAPITestCase(TestBase):
# Now create the two breakpoints inside function 'a'.
breakpoint1 = target.BreakpointCreateByLocation('main.c', self.line1)
breakpoint2 = target.BreakpointCreateByLocation('main.c', self.line2)
#print("breakpoint1:", breakpoint1)
#print("breakpoint2:", breakpoint2)
self.trace("breakpoint1:", breakpoint1)
self.trace("breakpoint2:", breakpoint2)
self.assertTrue(breakpoint1 and
breakpoint1.GetNumLocations() == 1,
VALID_BREAKPOINT)
@@ -64,7 +64,7 @@ class DisasmAPITestCase(TestBase):
self.assertTrue(lineEntry.GetLine() == self.line1)
address1 = lineEntry.GetStartAddress()
#print("address1:", address1)
self.trace("address1:", address1)
# Now call SBTarget.ResolveSymbolContextForAddress() with address1.
context1 = target.ResolveSymbolContextForAddress(
@@ -103,15 +103,11 @@ class DisasmAPITestCase(TestBase):
print("disassembly=>\n", disasm_output)
sa1 = symbol.GetStartAddress()
#print("sa1:", sa1)
#print("sa1.GetFileAddress():", hex(sa1.GetFileAddress()))
#ea1 = symbol.GetEndAddress()
#print("ea1:", ea1)
self.trace("sa1:", sa1)
self.trace("sa1.GetFileAddress():", hex(sa1.GetFileAddress()))
sa2 = function.GetStartAddress()
#print("sa2:", sa2)
#print("sa2.GetFileAddress():", hex(sa2.GetFileAddress()))
#ea2 = function.GetEndAddress()
#print("ea2:", ea2)
self.trace("sa2:", sa2)
self.trace("sa2.GetFileAddress():", hex(sa2.GetFileAddress()))
self.assertTrue(sa1 and sa2 and sa1 == sa2,
"The two starting addresses should be the same")