[lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
This commit is contained in:
@@ -48,7 +48,7 @@ class MemoryCacheTestCase(TestBase):
|
||||
|
||||
# Check the value of my_ints[0] is the same as set in main.cpp.
|
||||
line = self.res.GetOutput().splitlines()[100]
|
||||
self.assertTrue(0x00000042 == int(line.split(':')[1], 0))
|
||||
self.assertEquals(0x00000042, int(line.split(':')[1], 0))
|
||||
|
||||
# Change the value of my_ints[0] in memory.
|
||||
self.runCmd("memory write -s 4 `&my_ints` AA")
|
||||
@@ -59,4 +59,4 @@ class MemoryCacheTestCase(TestBase):
|
||||
|
||||
# Check the value of my_ints[0] have been updated correctly.
|
||||
line = self.res.GetOutput().splitlines()[100]
|
||||
self.assertTrue(0x000000AA == int(line.split(':')[1], 0))
|
||||
self.assertEquals(0x000000AA, int(line.split(':')[1], 0))
|
||||
|
||||
Reference in New Issue
Block a user