Cleanup and speedup NativeRegisterContextLinux_arm64

Summary:
This patch simplifies register accesses in NativeRegisterContextLinux_arm64
and also adds some bare minimum caching to avoid multiple calls to ptrace
during a stop.

Linux ptrace returns data in the form of structures containing GPR/FPR data.
This means that one single call is enough to read all GPRs or FPRs. We do
that once per stop and keep reading from or writing to the buffer that we
have in NativeRegisterContextLinux_arm64 class. Before a resume or detach we
write all buffers back.

This is tested on aarch64 thunder x1 with Ubuntu 18.04. Also tested
regressions on x86_64.

Reviewers: labath, clayborg

Reviewed By: labath

Subscribers: kristof.beyls, lldb-commits

Differential Revision: https://reviews.llvm.org/D69371
This commit is contained in:
Muhammad Omair Javaid
2019-12-06 22:12:39 +05:00
parent 03a242bd41
commit b6f9d7b8fb
4 changed files with 130 additions and 160 deletions

View File

@@ -241,6 +241,9 @@ Status NativeThreadLinux::Resume(uint32_t signo) {
if (signo != LLDB_INVALID_SIGNAL_NUMBER)
data = signo;
// Before thread resumes, clear any cached register data structures
GetRegisterContext().InvalidateAllRegisters();
return NativeProcessLinux::PtraceWrapper(PTRACE_CONT, GetID(), nullptr,
reinterpret_cast<void *>(data));
}
@@ -262,6 +265,9 @@ Status NativeThreadLinux::SingleStep(uint32_t signo) {
if (signo != LLDB_INVALID_SIGNAL_NUMBER)
data = signo;
// Before thread resumes, clear any cached register data structures
GetRegisterContext().InvalidateAllRegisters();
// If hardware single-stepping is not supported, we just do a continue. The
// breakpoint on the next instruction has been setup in
// NativeProcessLinux::Resume.