caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't allow direct access to StreamString's internal buffer.

Browse Source 
This is a large API change that removes the two functions from
StreamString that return a std::string& and a const std::string&,
and instead provide one function which returns a StringRef.

Direct access to the underlying buffer violates the concept of
a "stream" which is intended to provide forward only access,
and makes porting to llvm::raw_ostream more difficult in the
future.

Differential Revision: https://reviews.llvm.org/D26698

llvm-svn: 287152
This commit is contained in:
Zachary Turner
2016-11-16 21:15:24 +00:00
parent 725dc14bb2
commit c156427ded
134 changed files with 448 additions and 453 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
View File

@@ -1,5 +1,4 @@
//===-- OperatingSystemPython.cpp --------------------------------*- C++
//-*-===//
//===-- OperatingSystemPython.cpp --------------------------------*- C++-*-===//
//
// The LLVM Compiler Infrastructure
//
@@ -197,7 +196,7 @@ bool OperatingSystemPython::UpdateThreadList(ThreadList &old_thread_list,
if (log) {
StreamString strm;
threads_list->Dump(strm);
log->Printf("threads_list = %s", strm.GetString().c_str());
log->Printf("threads_list = %s", strm.GetData());
}
const uint32_t num_threads = threads_list->GetSize();