From c19a3cb613bd43813f30d98d34808430ff95b202 Mon Sep 17 00:00:00 2001 From: Ross Brunton Date: Tue, 20 May 2025 14:50:26 +0100 Subject: [PATCH] [Offload] Make OffloadAPI gtest error messages more readable (#140728) --- offload/unittests/OffloadAPI/common/Fixtures.hpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/offload/unittests/OffloadAPI/common/Fixtures.hpp b/offload/unittests/OffloadAPI/common/Fixtures.hpp index 2303601feb93..ff3c1f419480 100644 --- a/offload/unittests/OffloadAPI/common/Fixtures.hpp +++ b/offload/unittests/OffloadAPI/common/Fixtures.hpp @@ -15,7 +15,14 @@ #pragma once #ifndef ASSERT_SUCCESS -#define ASSERT_SUCCESS(ACTUAL) ASSERT_EQ(OL_SUCCESS, ACTUAL) +#define ASSERT_SUCCESS(ACTUAL) \ + do { \ + ol_result_t Res = ACTUAL; \ + if (Res && Res->Code != OL_ERRC_SUCCESS) { \ + GTEST_FAIL() << #ACTUAL " returned " << Res->Code << ": " \ + << Res->Details; \ + } \ + } while (0) #endif // TODO: rework this so the EXPECTED/ACTUAL results are readable