caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Remove FileSpec::GetLastPathComponent

Browse Source 
As far as I can tell, this just computes the filename of the FileSpec,
which is already conveniently stored in m_filename. We can use
FileSpec::GetFilename() instead.

Differential Revision: https://reviews.llvm.org/D149663
This commit is contained in:
Alex Langford
2023-05-02 10:05:36 -07:00
parent 50e79d725c
commit c4f3f5225d
8 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
View File

@@ -166,7 +166,7 @@ static UUID GetCoffUUID(llvm::object::COFFObjectFile &coff_obj) {
auto raw_data = coff_obj.getData();
LLDB_SCOPED_TIMERF(
"Calculating module crc32 %s with size %" PRIu64 " KiB",
FileSpec(coff_obj.getFileName()).GetLastPathComponent().AsCString(),
FileSpec(coff_obj.getFileName()).GetFilename().AsCString(),
static_cast<lldb::offset_t>(raw_data.size()) / 1024);
gnu_debuglink_crc = llvm::crc32(0, llvm::arrayRefFromStringRef(raw_data));
}
@@ -295,7 +295,7 @@ size_t ObjectFilePECOFF::GetModuleSpecifications(
const auto *map = GetGlobalPluginProperties().ModuleABIMap();
if (map->GetNumValues() > 0) {
// Step 1: Try with the exact file name.
auto name = file.GetLastPathComponent();
auto name = file.GetFilename();
module_env_option = map->GetValueForKey(name);
if (!module_env_option) {
// Step 2: Try with the file name in lowercase.